Skip to content
This repository has been archived by the owner on Mar 24, 2023. It is now read-only.

Fib using array + panic + some u32 #63

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from
Draft

Fib using array + panic + some u32 #63

wants to merge 11 commits into from

Conversation

0xLucqs
Copy link
Contributor

@0xLucqs 0xLucqs commented Mar 6, 2023

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Testing
  • Other (please describe):

What is the current behavior?

Issue Number: Fixes #5

What is the new behavior?

  • Can compile fib using an array
  • support u32
  • support panic
  • support enum

Does this introduce a breaking change?

  • Yes
  • No

Other information

@0xLucqs 0xLucqs requested a review from AbdelStark as a code owner March 6, 2023 15:55
@0xLucqs 0xLucqs marked this pull request as draft March 6, 2023 15:56
@github-actions
Copy link

github-actions bot commented Mar 6, 2023

Benchmark for 1a882e8

Click to view benchmark
Test Base PR %
Cairo/1 162.1±0.67ms 163.2±1.07ms +0.68%
Llvm/1 5.5±0.04ms 5.5±0.01ms 0.00%

@github-actions
Copy link

github-actions bot commented Mar 6, 2023

Benchmark for 567950c

Click to view benchmark
Test Base PR %
Cairo/1 174.5±3.24ms 178.2±5.10ms +2.12%
Llvm/1 5.7±0.25ms 5.8±0.25ms +1.75%

@github-actions
Copy link

github-actions bot commented Mar 6, 2023

Benchmark for e739023

Click to view benchmark
Test Base PR %
Cairo/1 161.2±0.75ms 155.4±0.49ms -3.60%
Llvm/1 5.5±0.00ms 5.5±0.02ms 0.00%

@codecov
Copy link

codecov bot commented Mar 6, 2023 •
edited
Loading

Codecov Report

Patch coverage: 5.91% and project coverage change: -7.75 ⚠️

Comparison is base (43e33bf) 86.27% compared to head (4e2e4e9) 78.52%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #63      +/-   ##
==========================================
- Coverage   86.27%   78.52%   -7.75%     
==========================================
  Files          36       43       +7     
  Lines        1741     1914     +173     
==========================================
+ Hits         1502     1503       +1     
- Misses        239      411     +172
Impacted Files Coverage Δ
core/src/main.rs 12.50% <0.00%> (ø)
core/src/sierra/corelib_functions/array/append.rs 0.00% <0.00%> (ø)
core/src/sierra/corelib_functions/array/new.rs 0.00% <0.00%> (ø)
core/src/sierra/process/debug.rs 100.00% <ø> (ø)
core/src/sierra/process/types.rs 73.91% <0.00%> (-20.54%) ⬇️
core/src/sierra/types/array.rs 0.00% <0.00%> (ø)
core/src/sierra/types/builtins/range_check.rs 0.00% <0.00%> (ø)
core/src/sierra/types/math/felt.rs 100.00% <ø> (ø)
core/src/sierra/types/math/non_zero.rs 85.00% <ø> (ø)
core/src/sierra/types/math/sierra_u32.rs 0.00% <0.00%> (ø)
... and 7 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link

github-actions bot commented Mar 6, 2023

Benchmark for c38ff4c

Click to view benchmark
Test Base PR %
Cairo/1 168.4±0.48ms 166.4±0.40ms -1.19%
Llvm/1 5.8±0.00ms 5.8±0.04ms 0.00%

@github-actions
Copy link

github-actions bot commented Mar 6, 2023

Benchmark for 0689e6e

Click to view benchmark
Test Base PR %
Cairo/1 152.4±0.61ms 155.9±0.73ms +2.30%
Llvm/1 5.5±0.01ms 5.6±0.04ms +1.82%

@github-actions
Copy link

github-actions bot commented Mar 6, 2023

Benchmark for ec28d9d

Click to view benchmark
Test Base PR %
Cairo/1 205.4±5.79ms 195.9±8.46ms -4.63%
Llvm/1 7.7±0.31ms 7.6±0.18ms -1.30%

@github-actions
Copy link

github-actions bot commented Mar 7, 2023

Benchmark for 4dbf2f8

Click to view benchmark
Test Base PR %
Cairo/1 156.6±0.73ms 154.9±0.63ms -1.09%
Llvm/1 5.5±0.01ms 5.5±0.01ms 0.00%

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AbdelStark AbdelStark Awaiting requested review from AbdelStark

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fibonacci array
1 participant
@0xLucqs